Support providing a filename unconditionally, when passing binary data to PDFViewerApplication.open#21249
Merged
Snuffleupagus merged 1 commit intoMay 10, 2026
Conversation
…ata to `PDFViewerApplication.open` Previously this was only supported in Firefox, however when merging PDFs the `PDFViewerApplication.onSaveAndLoad` method will provide a `filename` unconditionally.
Snuffleupagus
temporarily deployed
to
code-coverage
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
GitHub Actions
Inactive
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #21249 +/- ##
==========================================
+ Coverage 54.57% 56.00% +1.43%
==========================================
Files 216 220 +4
Lines 58860 58964 +104
==========================================
+ Hits 32120 33020 +900
+ Misses 26740 25944 -796
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously this was only supported in Firefox, however when merging PDFs the
PDFViewerApplication.onSaveAndLoadmethod will provide afilenameunconditionally.