Skip to content

Move the getModificationDate helper function into src/core/core_utils.js#21258

Merged
timvandermeij merged 1 commit into
mozilla:masterfrom
Snuffleupagus:mv-getModificationDate
May 11, 2026
Merged

Move the getModificationDate helper function into src/core/core_utils.js#21258
timvandermeij merged 1 commit into
mozilla:masterfrom
Snuffleupagus:mv-getModificationDate

Conversation

@Snuffleupagus
Copy link
Copy Markdown
Collaborator

Given that this function is only ever used in src/core/ code, let's avoid a little bit of dead code in the built pdf.mjs file.

Also, place the AnnotationPrefix and AnnotationEditorPrefix constants together in src/shared/util.js since that should aid readability.

…ils.js`

Given that this function is only ever used in `src/core/` code, let's avoid a little bit of dead code in the *built* `pdf.mjs` file.

Also, place the `AnnotationPrefix` and `AnnotationEditorPrefix` constants together in `src/shared/util.js` since that should aid readability.
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 11, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 56.05%. Comparing base (702d60a) to head (aecb571).

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #21258      +/-   ##
==========================================
- Coverage   56.05%   56.05%   -0.01%     
==========================================
  Files         220      220              
  Lines       58971    58971              
==========================================
- Hits        33056    33054       -2     
- Misses      25915    25917       +2     
Flag Coverage Δ
fonttest 8.65% <20.00%> (ø)
unittest 55.33% <100.00%> (+<0.01%) ⬆️
unittestcli 54.57% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@timvandermeij timvandermeij merged commit 6bbcb46 into mozilla:master May 11, 2026
22 checks passed
@timvandermeij
Copy link
Copy Markdown
Contributor

Good idea; thanks!

@Snuffleupagus Snuffleupagus deleted the mv-getModificationDate branch May 12, 2026 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants