Move the getModificationDate helper function into src/core/core_utils.js#21258
Merged
timvandermeij merged 1 commit intoMay 11, 2026
Merged
Conversation
…ils.js` Given that this function is only ever used in `src/core/` code, let's avoid a little bit of dead code in the *built* `pdf.mjs` file. Also, place the `AnnotationPrefix` and `AnnotationEditorPrefix` constants together in `src/shared/util.js` since that should aid readability.
a87fea7 to
aecb571
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #21258 +/- ##
==========================================
- Coverage 56.05% 56.05% -0.01%
==========================================
Files 220 220
Lines 58971 58971
==========================================
- Hits 33056 33054 -2
- Misses 25915 25917 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
timvandermeij
approved these changes
May 11, 2026
Contributor
|
Good idea; thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Given that this function is only ever used in
src/core/code, let's avoid a little bit of dead code in the builtpdf.mjsfile.Also, place the
AnnotationPrefixandAnnotationEditorPrefixconstants together insrc/shared/util.jssince that should aid readability.