Avoid bundling DOM-related code in the built pdf.worker.mjs file#21269
Conversation
Currently the `isCanvasFilterSupported`/`isAlphaColorInputSupported` getters, on the `FeatureTest` class, contains code that cannot run in the worker-thread since it relies on the DOM being available. To avoid that a new DEFINE is added, in `gulpfile.mjs`, to allow skipping this sort of dead code in the built `pdf.worker.mjs` file.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #21269 +/- ##
==========================================
+ Coverage 54.70% 56.17% +1.46%
==========================================
Files 216 220 +4
Lines 59131 59234 +103
==========================================
+ Hits 32347 33274 +927
+ Misses 26784 25960 -824
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
/botio browsertest |
From: Bot.io (Linux m4)ReceivedCommand cmd_browsertest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/94964f75c1f8b4f/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_browsertest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/7b8a6eb374a2e50/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/94964f75c1f8b4f/output.txt Total script time: 18.30 mins
Image differences available at: http://54.241.84.105:8877/94964f75c1f8b4f/reftest-analyzer.html#web=eq.log |
timvandermeij
left a comment
There was a problem hiding this comment.
r=me; thank you for improving this!
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/7b8a6eb374a2e50/output.txt Total script time: 24.53 mins
Image differences available at: http://54.193.163.58:8877/7b8a6eb374a2e50/reftest-analyzer.html#web=eq.log |
Currently the
isCanvasFilterSupported/isAlphaColorInputSupportedgetters, on theFeatureTestclass, contains code that cannot run in the worker-thread since it relies on the DOM being available.To avoid that a new DEFINE is added, in
gulpfile.mjs, to allow skipping this sort of dead code in the builtpdf.worker.mjsfile.