Upgrade Puppeteer to version 25.1.0 by timvandermeij · Pull Request #21285 · mozilla/pdf.js

timvandermeij · 2026-05-16T13:51:47Z

This is a major version bump, but the changelog at https://github.com/puppeteer/puppeteer/releases/tag/puppeteer-core-v25.0.0 doesn't indicate any breaking changes that should impact us.

Moreover, this release contains the fix for the memory leak from puppeteer/puppeteer#14876, so we can remove the workaround related to that now.

Finally, we rename .puppeteerrc to .puppeteerrc.json because of puppeteer/puppeteer#15076, but in general it's a good idea to be explicit about the file format via its extension, so even if this upstream bug is fixed we don't need to revert this.

codecov-commenter · 2026-05-16T13:52:59Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.45%. Comparing base (e7f951d) to head (b9b7661).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #21285      +/-   ##
==========================================
+ Coverage   81.23%   81.45%   +0.21%     
==========================================
  Files         258      258              
  Lines       65807    65807              
==========================================
+ Hits        53459    53601     +142     
+ Misses      12348    12206     -142

Flag	Coverage Δ
fonttest	`9.01% <ø> (ø)`
integrationtest	`66.71% <ø> (+0.08%)`	⬆️
unittest	`57.05% <ø> (+0.53%)`	⬆️
unittestcli	`55.98% <ø> (-0.01%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

calixteman · 2026-05-16T14:41:04Z

/boitio browsertest

timvandermeij · 2026-05-16T14:45:27Z

/botio browsertest

moz-tools-bot · 2026-05-16T14:45:30Z

From: Bot.io (Linux m4)

Received

Command cmd_browsertest from @timvandermeij received. Current queue size: 1

Live output at: http://54.241.84.105:8877/09dbcd1910bfc39/output.txt

moz-tools-bot · 2026-05-16T14:45:30Z

From: Bot.io (Windows)

Received

Command cmd_browsertest from @timvandermeij received. Current queue size: 1

Live output at: http://54.193.163.58:8877/c46d670414223fd/output.txt

moz-tools-bot · 2026-05-16T14:58:34Z

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/c46d670414223fd/output.txt

Total script time: 2.21 mins

Regression tests: FAILED

Image differences available at: http://54.193.163.58:8877/c46d670414223fd/reftest-analyzer.html#web=eq.log

moz-tools-bot · 2026-05-16T15:08:22Z

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/09dbcd1910bfc39/output.txt

Total script time: 18.51 mins

Regression tests: Passed

timvandermeij · 2026-05-16T15:09:48Z

/botio-windows browsertest

moz-tools-bot · 2026-05-16T15:09:51Z

From: Bot.io (Windows)

Received

Command cmd_browsertest from @timvandermeij received. Current queue size: 0

Live output at: http://54.193.163.58:8877/e3f3717caaec26d/output.txt

moz-tools-bot · 2026-05-16T15:11:22Z

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/e3f3717caaec26d/output.txt

Total script time: 1.51 mins

Regression tests: FAILED

Image differences available at: http://54.193.163.58:8877/e3f3717caaec26d/reftest-analyzer.html#web=eq.log

timvandermeij · 2026-05-16T15:14:43Z

@calixteman It looks like an earlier download/unpacking failed and left the cache directory in a partial state. Could you perhaps clear C:\Users\Administrator\.cache\puppeteer on the Windows bot so we can try again?

calixteman · 2026-05-25T14:05:22Z

/botio browsertest

moz-tools-bot · 2026-05-25T14:05:26Z

From: Bot.io (Linux m4)

Received

Command cmd_browsertest from @calixteman received. Current queue size: 2

Live output at: http://54.241.84.105:8877/52bf563290e6462/output.txt

moz-tools-bot · 2026-05-25T14:05:26Z

From: Bot.io (Windows)

Received

Command cmd_browsertest from @calixteman received. Current queue size: 2

Live output at: http://54.193.163.58:8877/ca8090927c3334a/output.txt

moz-tools-bot · 2026-05-25T14:38:31Z

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/ca8090927c3334a/output.txt

Total script time: 2.34 mins

Regression tests: FAILED

Image differences available at: http://54.193.163.58:8877/ca8090927c3334a/reftest-analyzer.html#web=eq.log

moz-tools-bot · 2026-05-25T14:49:20Z

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/52bf563290e6462/output.txt

Total script time: 18.46 mins

Regression tests: Passed

calixteman · 2026-05-29T18:09:40Z

/botio browsertest

moz-tools-bot · 2026-05-29T18:09:43Z

From: Bot.io (Windows)

Received

Command cmd_browsertest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/0c8a6f84ab8550d/output.txt

moz-tools-bot · 2026-05-29T18:09:43Z

From: Bot.io (Linux m4)

Received

Command cmd_browsertest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/cc1aa11a00c2b43/output.txt

moz-tools-bot · 2026-05-29T18:11:21Z

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/0c8a6f84ab8550d/output.txt

Total script time: 1.62 mins

Regression tests: FAILED

Image differences available at: http://54.193.163.58:8877/0c8a6f84ab8550d/reftest-analyzer.html#web=eq.log

This is a major version bump, but the changelog at https://github.com/puppeteer/puppeteer/releases/tag/puppeteer-core-v25.0.0 doesn't indicate any breaking changes that should impact us. Moreover, this release contains the fix for the memory leak from puppeteer/puppeteer#14876, so we can remove the workaround related to that now. Finally, we rename `.puppeteerrc` to `.puppeteerrc.json` because of puppeteer/puppeteer#15076, but in general it's a good idea to be explicit about the file format via its extension, so even if this upstream bug is fixed we don't need to revert this.

moz-tools-bot · 2026-05-29T18:28:18Z

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/cc1aa11a00c2b43/output.txt

Total script time: 18.57 mins

Regression tests: Passed

timvandermeij · 2026-05-29T18:29:32Z

/botio-windows browsertest

moz-tools-bot · 2026-05-29T18:29:36Z

From: Bot.io (Windows)

Received

Command cmd_browsertest from @timvandermeij received. Current queue size: 0

Live output at: http://54.193.163.58:8877/f094139d151e071/output.txt

timvandermeij · 2026-05-29T18:37:05Z

/botio-linux browsertest

moz-tools-bot · 2026-05-29T18:37:09Z

From: Bot.io (Linux m4)

Received

Command cmd_browsertest from @timvandermeij received. Current queue size: 0

Live output at: http://54.241.84.105:8877/10104f82f71f2d4/output.txt

moz-tools-bot · 2026-05-29T18:54:26Z

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/f094139d151e071/output.txt

Total script time: 24.82 mins

Regression tests: Passed

moz-tools-bot · 2026-05-29T18:55:31Z

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/10104f82f71f2d4/output.txt

Total script time: 18.35 mins

Regression tests: Passed

calixteman

LGTM. Thank you.

timvandermeij added test dependencies labels May 16, 2026

timvandermeij temporarily deployed to code-coverage May 16, 2026 13:51 — with GitHub Actions Inactive

timvandermeij had a problem deploying to code-coverage May 16, 2026 13:51 — with GitHub Actions Failure

timvandermeij temporarily deployed to code-coverage May 16, 2026 13:51 — with GitHub Actions Inactive

timvandermeij marked this pull request as ready for review May 16, 2026 13:52

timvandermeij requested a review from calixteman May 16, 2026 14:38

timvandermeij temporarily deployed to code-coverage May 25, 2026 13:33 — with GitHub Actions Inactive

timvandermeij mentioned this pull request May 29, 2026

Re-factor how "internal" EventBus listeners are handled in the viewer #21355

Merged

timvandermeij mentioned this pull request May 29, 2026

[Bug]: Loading .puppeteerrc broken between Puppeteer 25.0.4 and 25.1.0 puppeteer/puppeteer#15076

Open

calixteman approved these changes May 29, 2026

View reviewed changes

Conversation

timvandermeij commented May 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov-commenter commented May 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

calixteman commented May 16, 2026

Uh oh!

timvandermeij commented May 16, 2026

Uh oh!

moz-tools-bot commented May 16, 2026

From: Bot.io (Linux m4)

Received

Uh oh!

moz-tools-bot commented May 16, 2026

From: Bot.io (Windows)

Received

Uh oh!

moz-tools-bot commented May 16, 2026

From: Bot.io (Windows)

Failed

Uh oh!

moz-tools-bot commented May 16, 2026

From: Bot.io (Linux m4)

Success

Uh oh!

timvandermeij commented May 16, 2026

Uh oh!

moz-tools-bot commented May 16, 2026

From: Bot.io (Windows)

Received

Uh oh!

moz-tools-bot commented May 16, 2026

From: Bot.io (Windows)

Failed

Uh oh!

timvandermeij commented May 16, 2026

Uh oh!

calixteman commented May 25, 2026

Uh oh!

moz-tools-bot commented May 25, 2026

From: Bot.io (Linux m4)

Received

Uh oh!

moz-tools-bot commented May 25, 2026

From: Bot.io (Windows)

Received

Uh oh!

moz-tools-bot commented May 25, 2026

From: Bot.io (Windows)

Failed

Uh oh!

moz-tools-bot commented May 25, 2026

From: Bot.io (Linux m4)

Success

Uh oh!

calixteman commented May 29, 2026

Uh oh!

moz-tools-bot commented May 29, 2026

From: Bot.io (Windows)

Received

Uh oh!

moz-tools-bot commented May 29, 2026

From: Bot.io (Linux m4)

Received

Uh oh!

moz-tools-bot commented May 29, 2026

From: Bot.io (Windows)

Failed

Uh oh!

moz-tools-bot commented May 29, 2026

From: Bot.io (Linux m4)

Success

Uh oh!

timvandermeij commented May 29, 2026

Uh oh!

moz-tools-bot commented May 29, 2026

From: Bot.io (Windows)

timvandermeij commented May 16, 2026 •

edited

Loading

codecov-commenter commented May 16, 2026 •

edited

Loading