Skip to content

Remove the unused Outline._normalizePagePoint method#21287

Merged
timvandermeij merged 1 commit into
mozilla:masterfrom
Snuffleupagus:rm-_normalizePagePoint
May 17, 2026
Merged

Remove the unused Outline._normalizePagePoint method#21287
timvandermeij merged 1 commit into
mozilla:masterfrom
Snuffleupagus:rm-_normalizePagePoint

Conversation

@Snuffleupagus
Copy link
Copy Markdown
Collaborator

This method was added in PR #19093, back in 2024, however it never actually appears to have been used.

This method was added in PR 19093, back in 2024, however it never actually appears to have been used.
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 16, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.96%. Comparing base (65b8aec) to head (036436a).

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #21287      +/-   ##
==========================================
+ Coverage   80.94%   80.96%   +0.02%     
==========================================
  Files         256      256              
  Lines       64855    64850       -5     
==========================================
+ Hits        52497    52506       +9     
+ Misses      12358    12344      -14     
Flag Coverage Δ
fonttest 8.65% <ø> (ø)
integrationtest 66.19% <ø> (+<0.01%) ⬆️
unittest 57.09% <ø> (+0.02%) ⬆️
unittestcli 56.28% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

@timvandermeij timvandermeij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, with passing browser tests just to be extra sure. Thank you!

@timvandermeij
Copy link
Copy Markdown
Contributor

/botio browsertest

@moz-tools-bot
Copy link
Copy Markdown
Collaborator

From: Bot.io (Windows)


Received

Command cmd_browsertest from @timvandermeij received. Current queue size: 0

Live output at: http://54.193.163.58:8877/dfb2989435f1568/output.txt

@moz-tools-bot
Copy link
Copy Markdown
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_browsertest from @timvandermeij received. Current queue size: 0

Live output at: http://54.241.84.105:8877/eefe59c5653e66c/output.txt

@moz-tools-bot
Copy link
Copy Markdown
Collaborator

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/dfb2989435f1568/output.txt

Total script time: 1.63 mins

  • Regression tests: FAILED

Image differences available at: http://54.193.163.58:8877/dfb2989435f1568/reftest-analyzer.html#web=eq.log

@moz-tools-bot
Copy link
Copy Markdown
Collaborator

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/eefe59c5653e66c/output.txt

Total script time: 18.41 mins

  • Regression tests: Passed

@timvandermeij timvandermeij merged commit f290da0 into mozilla:master May 17, 2026
22 checks passed
@Snuffleupagus Snuffleupagus deleted the rm-_normalizePagePoint branch May 17, 2026 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants