Remove the unused Outline._normalizePagePoint method#21287
Conversation
This method was added in PR 19093, back in 2024, however it never actually appears to have been used.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #21287 +/- ##
==========================================
+ Coverage 80.94% 80.96% +0.02%
==========================================
Files 256 256
Lines 64855 64850 -5
==========================================
+ Hits 52497 52506 +9
+ Misses 12358 12344 -14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
timvandermeij
left a comment
There was a problem hiding this comment.
r=me, with passing browser tests just to be extra sure. Thank you!
|
/botio browsertest |
From: Bot.io (Windows)ReceivedCommand cmd_browsertest from @timvandermeij received. Current queue size: 0 Live output at: http://54.193.163.58:8877/dfb2989435f1568/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_browsertest from @timvandermeij received. Current queue size: 0 Live output at: http://54.241.84.105:8877/eefe59c5653e66c/output.txt |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/dfb2989435f1568/output.txt Total script time: 1.63 mins
Image differences available at: http://54.193.163.58:8877/dfb2989435f1568/reftest-analyzer.html#web=eq.log |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/eefe59c5653e66c/output.txt Total script time: 18.41 mins
|
This method was added in PR #19093, back in 2024, however it never actually appears to have been used.