Add an integration-test for the page-name fuzzy matching in the PDFDocumentProperties dialog#21289
Merged
timvandermeij merged 1 commit intoMay 17, 2026
Conversation
Snuffleupagus
had a problem deploying
to
code-coverage
GitHub Actions
Error
Snuffleupagus
temporarily deployed
to
code-coverage
GitHub Actions
Inactive
Snuffleupagus
had a problem deploying
to
code-coverage
GitHub Actions
Error
Snuffleupagus
temporarily deployed
to
code-coverage
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
GitHub Actions
Inactive
Snuffleupagus
had a problem deploying
to
code-coverage
GitHub Actions
Error
Snuffleupagus
had a problem deploying
to
code-coverage
GitHub Actions
Error
Snuffleupagus
changed the title
PDFDocumentProperties dialogPDFDocumentProperties dialog
…ocumentProperties` dialog Also, test that closing the dialog works correctly.
Snuffleupagus
force-pushed
the
PDFDocumentProperties-approx-size-test
branch
from
c623a47 to
afa9b6e
Compare
Snuffleupagus
temporarily deployed
to
code-coverage
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
GitHub Actions
Inactive
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #21289 +/- ##
==========================================
+ Coverage 80.95% 80.97% +0.01%
==========================================
Files 256 256
Lines 64850 64850
==========================================
+ Hits 52502 52512 +10
+ Misses 12348 12338 -10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
timvandermeij
approved these changes
May 17, 2026
Contributor
timvandermeij
left a comment
timvandermeij
left a comment
There was a problem hiding this comment.
r=me; thank you for improving the test coverage of this component!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also, test that closing the dialog works correctly.