Disable hardware acceleration for Chrome tests by timvandermeij · Pull Request #21299 · mozilla/pdf.js

timvandermeij · 2026-05-19T18:50:05Z

This commit fixes the rendering issue that makes the "must update an existing annotation" ink editor integration test permafail locally in Chrome. Note that we already do this for Firefox tests, so this also improves consistency between the two browsers.

Moreover, improve how we define Chrome options to (similar to their Firefox counterparts) provide them in a single array, and document the reasoning for why these options are being set more explicitly.

Fixes #21272.

codecov-commenter · 2026-05-19T18:59:35Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.28%. Comparing base (f500cff) to head (6059138).

Additional details and impacted files

@@           Coverage Diff           @@
##           master   #21299   +/-   ##
=======================================
  Coverage   81.28%   81.28%           
=======================================
  Files         256      256           
  Lines       64873    64873           
=======================================
+ Hits        52730    52732    +2     
+ Misses      12143    12141    -2

Flag	Coverage Δ
fonttest	`8.68% <ø> (ø)`
integrationtest	`66.78% <ø> (+<0.01%)`	⬆️
unittest	`57.08% <ø> (-0.02%)`	⬇️
unittestcli	`56.31% <ø> (+0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

This commit fixes the rendering issue that makes the "must update an existing annotation" ink editor integration test permafail locally in Chrome. Note that we already do this for Firefox tests, so this also improves consistency between the two browsers. Moreover, improve how we define Chrome options to (similar to their Firefox counterparts) provide them in a single array, and document the reasoning for why these options are being set more explicitly. Fixes mozilla#21272.

calixteman

LGTM. Thank you.

timvandermeij · 2026-05-19T19:44:48Z

/botio-linux browsertest

moz-tools-bot · 2026-05-19T19:44:52Z

From: Bot.io (Linux m4)

Received

Command cmd_browsertest from @timvandermeij received. Current queue size: 0

Live output at: http://54.241.84.105:8877/c582eb628107ce7/output.txt

moz-tools-bot · 2026-05-19T20:03:18Z

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/c582eb628107ce7/output.txt

Total script time: 18.42 mins

Regression tests: Passed

timvandermeij added the test label May 19, 2026

timvandermeij had a problem deploying to code-coverage May 19, 2026 18:50 — with GitHub Actions Error

timvandermeij temporarily deployed to code-coverage May 19, 2026 18:50 — with GitHub Actions Inactive

timvandermeij had a problem deploying to code-coverage May 19, 2026 18:50 — with GitHub Actions Error

timvandermeij temporarily deployed to code-coverage May 19, 2026 18:50 — with GitHub Actions Inactive

timvandermeij had a problem deploying to code-coverage May 19, 2026 18:50 — with GitHub Actions Error

timvandermeij temporarily deployed to code-coverage May 19, 2026 18:50 — with GitHub Actions Inactive

timvandermeij had a problem deploying to code-coverage May 19, 2026 18:50 — with GitHub Actions Error

timvandermeij temporarily deployed to code-coverage May 19, 2026 18:50 — with GitHub Actions Inactive

timvandermeij had a problem deploying to code-coverage May 19, 2026 18:50 — with GitHub Actions Error

timvandermeij force-pushed the disable-gpu branch from 1857d4d to d737d23 Compare May 19, 2026 19:04

timvandermeij had a problem deploying to code-coverage May 19, 2026 19:04 — with GitHub Actions Error