Allow merging a PDF by dropping it onto the thumbnail viewer#21306
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #21306 +/- ##
==========================================
+ Coverage 81.27% 81.34% +0.06%
==========================================
Files 256 256
Lines 64873 65207 +334
==========================================
+ Hits 52728 53040 +312
- Misses 12145 12167 +22
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Drop an external PDF anywhere in the views-manager thumbnail sidebar to merge it at the cursor, rather than always inserting after the current page via the "Add file" button. The drop reuses the blue separator from page-move drag so the user can see exactly where the inserted pages will land, and the merge path is shared with the existing picker so post-merge selection/current-page behavior stays consistent.
calixteman
force-pushed
the
dnd_pdf_merging
branch
from
fcb62ac to
d79043b
Compare
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://54.241.84.105:8877/4f2a2c55d0351cd/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/4f2a2c55d0351cd/output.txt Total script time: 1.21 mins Published |
|
This seems to work just fine, and splitting the logic into smaller methods helps for readability of the code. Thank you! |
5 participants
Drop an external PDF anywhere in the views-manager thumbnail sidebar to merge it at the cursor, rather than always inserting after the current page via the "Add file" button.
The drop reuses the blue separator from page-move drag so the user can see exactly where the inserted pages will land, and the merge path is shared with the existing picker so post-merge selection/current-page behavior stays consistent.