Keep the first /Subrs and /CharStrings block#21315
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #21315 +/- ##
==========================================
+ Coverage 81.39% 81.42% +0.02%
==========================================
Files 256 257 +1
Lines 65337 65327 -10
==========================================
+ Hits 53183 53191 +8
+ Misses 12154 12136 -18
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
/botio browsertest |
From: Bot.io (Windows)ReceivedCommand cmd_browsertest from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/a5721ceccb6f98e/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_browsertest from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/9f3ca7cba3932c5/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/9f3ca7cba3932c5/output.txt Total script time: 7.37 mins
Image differences available at: http://54.241.84.105:8877/9f3ca7cba3932c5/reftest-analyzer.html#web=eq.log |
|
/botio-linux browsertest |
From: Bot.io (Linux m4)ReceivedCommand cmd_browsertest from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/7aaa2baf24d6791/output.txt |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/a5721ceccb6f98e/output.txt Total script time: 25.61 mins
Image differences available at: http://54.193.163.58:8877/a5721ceccb6f98e/reftest-analyzer.html#web=eq.log |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/7aaa2baf24d6791/output.txt Total script time: 18.56 mins
|
|
The "regressions" are improvements. |
timvandermeij
left a comment
There was a problem hiding this comment.
r=me, with the comment and merge conflict addressed. Thank you for improving this!
Some Type1 fonts (the embedded Optima variants in orw1972.pdf) ship two /Subrs and /CharStrings blocks wrapped in save/restore frames gated on an Adobe hires/lores runtime switch. In such cases, we just use the first /Subrs and /CharStrings block, which is the one that is actually used by the font renderer in Acrobat. It fixes mozilla#18548.
|
/botio browsertest |
From: Bot.io (Linux m4)ReceivedCommand cmd_browsertest from @calixteman received. Current queue size: 2 Live output at: http://54.241.84.105:8877/915b20044daef5f/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_browsertest from @calixteman received. Current queue size: 2 Live output at: http://54.193.163.58:8877/8126f388761c373/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/915b20044daef5f/output.txt Total script time: 18.56 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/8126f388761c373/output.txt Total script time: 25.16 mins
|
|
/botio makeref |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/dd7fa2027adb22a/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_makeref from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/18eabfa153108ce/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/18eabfa153108ce/output.txt Total script time: 18.23 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/dd7fa2027adb22a/output.txt Total script time: 25.12 mins
|
Some Type1 fonts (the embedded Optima variants in orw1972.pdf) ship two /Subrs and /CharStrings blocks wrapped in save/restore frames gated on an Adobe hires/lores runtime switch.
In such cases, we just use the first /Subrs and /CharStrings block, which is the one that is actually used by the font renderer in Acrobat.
It fixes #18548.