Skip to content

Shorten the XfaLayerBuilder.prototype.render method#21317

Merged
timvandermeij merged 1 commit into
mozilla:masterfrom
Snuffleupagus:XfaLayerBuilder-render-shorten
May 24, 2026
Merged

Shorten the XfaLayerBuilder.prototype.render method#21317
timvandermeij merged 1 commit into
mozilla:masterfrom
Snuffleupagus:XfaLayerBuilder-render-shorten

Conversation

@Snuffleupagus
Copy link
Copy Markdown
Collaborator

Given that the "print" intent is handled separately, there's currently a little bit of unnecessary code duplication in this method.

Given that the "print" intent is handled separately, there's currently a little bit of unnecessary code duplication in this method.
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 23, 2026

Codecov Report

❌ Patch coverage is 80.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.40%. Comparing base (25c7d9e) to head (bd14524).
⚠️ Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
web/xfa_layer_builder.js 80.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #21317      +/-   ##
==========================================
+ Coverage   81.38%   81.40%   +0.02%     
==========================================
  Files         256      256              
  Lines       65328    65322       -6     
==========================================
+ Hits        53165    53177      +12     
+ Misses      12163    12145      -18     
Flag Coverage Δ
integrationtest 66.98% <80.00%> (+0.02%) ⬆️
unittest 56.84% <0.00%> (-0.01%) ⬇️
unittestcli 56.05% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@timvandermeij timvandermeij merged commit d37e0b4 into mozilla:master May 24, 2026
24 of 26 checks passed
@timvandermeij
Copy link
Copy Markdown
Contributor

Looks good; thank you!

@Snuffleupagus Snuffleupagus deleted the XfaLayerBuilder-render-shorten branch May 25, 2026 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants