Fix the XRefWrapper implementation, in the src/core/editor/pdf_editor.js file#21319
Conversation
…tor.js` file When comparing this code with the full `XRef` class it doesn't seem to be entirely correctly implemented, since the `fetch` method is basically doing what the `fetchIfRef` method is intended to do.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #21319 +/- ##
==========================================
+ Coverage 81.38% 81.40% +0.02%
==========================================
Files 256 256
Lines 65328 65338 +10
==========================================
+ Hits 53165 53189 +24
+ Misses 12163 12149 -14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
/botio browsertest |
From: Bot.io (Windows)ReceivedCommand cmd_browsertest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/1721915db3e1f81/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_browsertest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/407f1448a6840c5/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/407f1448a6840c5/output.txt Total script time: 18.23 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/1721915db3e1f81/output.txt Total script time: 25.06 mins
|
|
Looks good; thanks! |
When comparing this code with the full
XRefclass it doesn't seem to be entirely correctly implemented, since thefetchmethod is basically doing what thefetchIfRefmethod is intended to do.