Skip to content

Fix the XRefWrapper implementation, in the src/core/editor/pdf_editor.js file#21319

Merged
timvandermeij merged 1 commit into
mozilla:masterfrom
Snuffleupagus:XRefWrapper-fix
May 24, 2026
Merged

Fix the XRefWrapper implementation, in the src/core/editor/pdf_editor.js file#21319
timvandermeij merged 1 commit into
mozilla:masterfrom
Snuffleupagus:XRefWrapper-fix

Conversation

@Snuffleupagus
Copy link
Copy Markdown
Collaborator

When comparing this code with the full XRef class it doesn't seem to be entirely correctly implemented, since the fetch method is basically doing what the fetchIfRef method is intended to do.

…tor.js` file

When comparing this code with the full `XRef` class it doesn't seem to be entirely correctly implemented, since the `fetch` method is basically doing what the `fetchIfRef` method is intended to do.
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 23, 2026

Codecov Report

❌ Patch coverage is 40.00000% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.40%. Comparing base (25c7d9e) to head (05de3c8).
⚠️ Report is 12 commits behind head on master.

Files with missing lines Patch % Lines
src/core/editor/pdf_editor.js 40.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #21319      +/-   ##
==========================================
+ Coverage   81.38%   81.40%   +0.02%     
==========================================
  Files         256      256              
  Lines       65328    65338      +10     
==========================================
+ Hits        53165    53189      +24     
+ Misses      12163    12149      -14     
Flag Coverage Δ
fonttest 9.11% <ø> (+<0.01%) ⬆️
integrationtest 66.98% <0.00%> (+0.02%) ⬆️
unittest 56.85% <40.00%> (-0.01%) ⬇️
unittestcli 56.05% <40.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Snuffleupagus
Copy link
Copy Markdown
Collaborator Author

/botio browsertest

@moz-tools-bot
Copy link
Copy Markdown
Collaborator

From: Bot.io (Windows)


Received

Command cmd_browsertest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/1721915db3e1f81/output.txt

@moz-tools-bot
Copy link
Copy Markdown
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_browsertest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/407f1448a6840c5/output.txt

@moz-tools-bot
Copy link
Copy Markdown
Collaborator

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/407f1448a6840c5/output.txt

Total script time: 18.23 mins

  • Regression tests: Passed

@moz-tools-bot
Copy link
Copy Markdown
Collaborator

From: Bot.io (Windows)


Success

Full output at http://54.193.163.58:8877/1721915db3e1f81/output.txt

Total script time: 25.06 mins

  • Regression tests: Passed

@timvandermeij timvandermeij merged commit 13a61b1 into mozilla:master May 24, 2026
25 of 26 checks passed
@timvandermeij
Copy link
Copy Markdown
Contributor

Looks good; thanks!

@Snuffleupagus Snuffleupagus deleted the XRefWrapper-fix branch May 25, 2026 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants