Substitute a system font when an embedded CFF is truncated#21320
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #21320 +/- ##
==========================================
- Coverage 81.42% 81.41% -0.01%
==========================================
Files 257 257
Lines 65328 65339 +11
==========================================
+ Hits 53191 53195 +4
- Misses 12137 12144 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
timvandermeij
left a comment
timvandermeij
left a comment
There was a problem hiding this comment.
r=me, with passing reference tests. Thank you for fixing this!
|
/botio browsertest |
From: Bot.io (Linux m4)ReceivedCommand cmd_browsertest from @calixteman received. Current queue size: 1 Live output at: http://54.241.84.105:8877/998f79a8fed7454/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_browsertest from @calixteman received. Current queue size: 1 Live output at: http://54.193.163.58:8877/75ddd573c487e23/output.txt |
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/75ddd573c487e23/output.txt Total script time: 24.80 mins
|
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/998f79a8fed7454/output.txt Total script time: 18.28 mins
Image differences available at: http://54.241.84.105:8877/998f79a8fed7454/reftest-analyzer.html#web=eq.log |
It fixes mozilla#7625. If the Top DICT's Private DICT extends past the end of the font data, the Local Subrs INDEX is unreachable and every CharString that calls a subr ends up as a blank glyph. Throw from parsePrivateDict so the existing catch in translateFont triggers fallbackToSystemFont, then run getFontSubstitution post-construction so we pick a close local match instead of the generic fallbackName.
|
/botio makeref |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @timvandermeij received. Current queue size: 0 Live output at: http://54.193.163.58:8877/740ce885f8b095c/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_makeref from @timvandermeij received. Current queue size: 0 Live output at: http://54.241.84.105:8877/4c533d2ef9bd516/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/4c533d2ef9bd516/output.txt Total script time: 18.26 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/740ce885f8b095c/output.txt Total script time: 24.88 mins
|
4 participants
It fixes #7625.
If the Top DICT's Private DICT extends past the end of the font data, the Local Subrs INDEX is unreachable and every CharString that calls a subr ends up as a blank glyph. Throw from parsePrivateDict so the existing catch in translateFont triggers fallbackToSystemFont, then run getFontSubstitution post-construction so we pick a close local match instead of the generic fallbackName.