Skip to content

Force the text selection color to be in light mode#21329

Merged
timvandermeij merged 1 commit into
mozilla:masterfrom
calixteman:fix_selection_color
May 25, 2026
Merged

Force the text selection color to be in light mode#21329
timvandermeij merged 1 commit into
mozilla:masterfrom
calixteman:fix_selection_color

Conversation

@calixteman
Copy link
Copy Markdown
Contributor

Most of the pdfs have a white background, so it makes sense to use the colors for light mode.

@calixteman calixteman requested a review from timvandermeij May 25, 2026 07:10
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 25, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.42%. Comparing base (5f2691e) to head (f7af3ea).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #21329   +/-   ##
=======================================
  Coverage   81.42%   81.42%           
=======================================
  Files         257      257           
  Lines       65339    65352   +13     
=======================================
+ Hits        53202    53214   +12     
- Misses      12137    12138    +1     
Flag Coverage Δ
fonttest 9.10% <ø> (-0.01%) ⬇️
integrationtest 67.00% <100.00%> (+<0.01%) ⬆️
unittest 56.87% <0.00%> (+<0.01%) ⬆️
unittestcli 56.09% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@timvandermeij
Copy link
Copy Markdown
Contributor

/botio browsertest

@moz-tools-bot
Copy link
Copy Markdown
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_browsertest from @timvandermeij received. Current queue size: 0

Live output at: http://54.241.84.105:8877/d0be6dae9548dc7/output.txt

@moz-tools-bot
Copy link
Copy Markdown
Collaborator

From: Bot.io (Windows)


Received

Command cmd_browsertest from @timvandermeij received. Current queue size: 0

Live output at: http://54.193.163.58:8877/3279eadb284dbe3/output.txt

Comment thread src/display/filter_factory.js Outdated
@moz-tools-bot
Copy link
Copy Markdown
Collaborator

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/d0be6dae9548dc7/output.txt

Total script time: 18.56 mins

  • Regression tests: Passed

@moz-tools-bot
Copy link
Copy Markdown
Collaborator

From: Bot.io (Windows)


Success

Full output at http://54.193.163.58:8877/3279eadb284dbe3/output.txt

Total script time: 25.11 mins

  • Regression tests: Passed

Most of the pdfs have a white background, so it makes sense to use the colors for light mode.
@timvandermeij timvandermeij merged commit 87b436d into mozilla:master May 25, 2026
21 of 22 checks passed
@timvandermeij
Copy link
Copy Markdown
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants