Enable 'eslint-plugin-regexp' and fix existing findings#21330
Conversation
Enable the recommended preset and fix or per-line-disable the 78 findings it surfaces. Most are equivalent rewrites, intentional patterns (control chars, the whatwg email regex, autolinker URL regex) keep their behavior via targeted disables.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #21330 +/- ##
=======================================
Coverage 81.42% 81.42%
=======================================
Files 257 257
Lines 65339 65352 +13
=======================================
+ Hits 53202 53216 +14
+ Misses 12137 12136 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
timvandermeij
left a comment
There was a problem hiding this comment.
r=me, with passing browser tests. Thanks!
|
/botio browsertest |
From: Bot.io (Linux m4)ReceivedCommand cmd_browsertest from @timvandermeij received. Current queue size: 1 Live output at: http://54.241.84.105:8877/ea5d365cd68fe59/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_browsertest from @timvandermeij received. Current queue size: 1 Live output at: http://54.193.163.58:8877/f52358de0e3c929/output.txt |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/f52358de0e3c929/output.txt Total script time: 9.74 mins
Image differences available at: http://54.193.163.58:8877/f52358de0e3c929/reftest-analyzer.html#web=eq.log |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/ea5d365cd68fe59/output.txt Total script time: 18.29 mins
|
Enable the recommended preset and fix or per-line-disable the 78 findings it surfaces. Most are equivalent rewrites, intentional patterns (control chars, the whatwg email regex, autolinker URL regex) keep their behavior via targeted disables.