Skip to content

Enable 'eslint-plugin-regexp' and fix existing findings#21330

Merged
timvandermeij merged 1 commit into
mozilla:masterfrom
calixteman:fix_regex
May 25, 2026
Merged

Enable 'eslint-plugin-regexp' and fix existing findings#21330
timvandermeij merged 1 commit into
mozilla:masterfrom
calixteman:fix_regex

Conversation

@calixteman
Copy link
Copy Markdown
Contributor

Enable the recommended preset and fix or per-line-disable the 78 findings it surfaces. Most are equivalent rewrites, intentional patterns (control chars, the whatwg email regex, autolinker URL regex) keep their behavior via targeted disables.

Enable the recommended preset and fix or per-line-disable the 78
findings it surfaces. Most are equivalent rewrites, intentional
patterns (control chars, the whatwg email regex, autolinker URL regex)
keep their behavior via targeted disables.
@calixteman calixteman requested a review from timvandermeij May 25, 2026 12:33
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 25, 2026

Codecov Report

❌ Patch coverage is 92.30769% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.42%. Comparing base (5f2691e) to head (7bda0fc).
⚠️ Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
src/display/annotation_layer.js 0.00% 1 Missing ⚠️
src/display/content_disposition.js 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master   #21330   +/-   ##
=======================================
  Coverage   81.42%   81.42%           
=======================================
  Files         257      257           
  Lines       65339    65352   +13     
=======================================
+ Hits        53202    53216   +14     
+ Misses      12137    12136    -1     
Flag Coverage Δ
fonttest 9.10% <14.28%> (-0.01%) ⬇️
integrationtest 67.11% <81.81%> (+0.11%) ⬆️
unittest 56.88% <88.00%> (+<0.01%) ⬆️
unittestcli 56.07% <80.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

@timvandermeij timvandermeij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, with passing browser tests. Thanks!

@timvandermeij
Copy link
Copy Markdown
Contributor

/botio browsertest

@moz-tools-bot
Copy link
Copy Markdown
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_browsertest from @timvandermeij received. Current queue size: 1

Live output at: http://54.241.84.105:8877/ea5d365cd68fe59/output.txt

@moz-tools-bot
Copy link
Copy Markdown
Collaborator

From: Bot.io (Windows)


Received

Command cmd_browsertest from @timvandermeij received. Current queue size: 1

Live output at: http://54.193.163.58:8877/f52358de0e3c929/output.txt

@moz-tools-bot
Copy link
Copy Markdown
Collaborator

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/f52358de0e3c929/output.txt

Total script time: 9.74 mins

  • Regression tests: FAILED
  errors: 5

Image differences available at: http://54.193.163.58:8877/f52358de0e3c929/reftest-analyzer.html#web=eq.log

@moz-tools-bot
Copy link
Copy Markdown
Collaborator

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/ea5d365cd68fe59/output.txt

Total script time: 18.29 mins

  • Regression tests: Passed

@timvandermeij timvandermeij merged commit d1c85f8 into mozilla:master May 25, 2026
25 of 26 checks passed
@calixteman calixteman deleted the fix_regex branch May 25, 2026 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants