Skip to content

Avoid a temporary variable and return results directly in a couple of functions#21332

Merged
Snuffleupagus merged 1 commit into
mozilla:masterfrom
Snuffleupagus:direct-return
May 25, 2026
Merged

Avoid a temporary variable and return results directly in a couple of functions#21332
Snuffleupagus merged 1 commit into
mozilla:masterfrom
Snuffleupagus:direct-return

Conversation

@Snuffleupagus
Copy link
Copy Markdown
Collaborator

No description provided.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 25, 2026

Codecov Report

❌ Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 81.42%. Comparing base (164ffb9) to head (48a12ac).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
src/core/font_renderer.js 66.66% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master   #21332   +/-   ##
=======================================
  Coverage   81.42%   81.42%           
=======================================
  Files         257      257           
  Lines       65352    65348    -4     
=======================================
  Hits        53211    53211           
+ Misses      12141    12137    -4     
Flag Coverage Δ
fonttest 9.10% <0.00%> (+<0.01%) ⬆️
integrationtest 67.00% <40.00%> (+0.01%) ⬆️
unittest 56.86% <0.00%> (-0.02%) ⬇️
unittestcli 56.07% <40.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread src/core/font_renderer.js Outdated
Copy link
Copy Markdown
Contributor

@calixteman calixteman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you.

@Snuffleupagus
Copy link
Copy Markdown
Collaborator Author

/botio browsertest

@moz-tools-bot
Copy link
Copy Markdown
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_browsertest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/559984ed2641cd6/output.txt

@moz-tools-bot
Copy link
Copy Markdown
Collaborator

From: Bot.io (Windows)


Received

Command cmd_browsertest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/bc2364fbbf2c60e/output.txt

@moz-tools-bot
Copy link
Copy Markdown
Collaborator

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/559984ed2641cd6/output.txt

Total script time: 18.26 mins

  • Regression tests: Passed

@moz-tools-bot
Copy link
Copy Markdown
Collaborator

From: Bot.io (Windows)


Success

Full output at http://54.193.163.58:8877/bc2364fbbf2c60e/output.txt

Total script time: 25.20 mins

  • Regression tests: Passed

@Snuffleupagus Snuffleupagus merged commit f156b81 into mozilla:master May 25, 2026
21 of 22 checks passed
@Snuffleupagus Snuffleupagus deleted the direct-return branch May 25, 2026 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants