Clamp out-of-range BlueScale to Adobe's valid window#21343
Conversation
Fonts that ship a BlueScale outside the range AFDKO considers valid for their zone heights (0.5/maxZoneHeight <= BlueScale <= 1/maxZoneHeight) cause Firefox's CFF rasterizer to misalign overshooting glyphs against flat-topped ones at body sizes. Clamp into that window, only apply the lower clamp when BlueScale is also smaller than the default, so foundry fonts that pair the default 0.039625 with small zones are untouched. Fixes mozilla#9437.
calixteman
had a problem deploying
to
code-coverage
GitHub Actions
Failure
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #21343 +/- ##
==========================================
+ Coverage 81.40% 81.43% +0.02%
==========================================
Files 257 257
Lines 65351 65365 +14
==========================================
+ Hits 53198 53228 +30
+ Misses 12153 12137 -16
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
timvandermeij
left a comment
timvandermeij
left a comment
There was a problem hiding this comment.
r= me, with passing reference tests. Thank you!
|
/botio browsertest |
From: Bot.io (Linux m4)ReceivedCommand cmd_browsertest from @calixteman received. Current queue size: 1 Live output at: http://54.241.84.105:8877/479687568c466f1/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_browsertest from @calixteman received. Current queue size: 1 Live output at: http://54.193.163.58:8877/281c741ac215b42/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/479687568c466f1/output.txt Total script time: 18.34 mins
Image differences available at: http://54.241.84.105:8877/479687568c466f1/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/281c741ac215b42/output.txt Total script time: 25.55 mins
Image differences available at: http://54.193.163.58:8877/281c741ac215b42/reftest-analyzer.html#web=eq.log |
|
/botio-windows browsertest |
From: Bot.io (Windows)ReceivedCommand cmd_browsertest from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/eaf88277c3117c5/output.txt |
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/eaf88277c3117c5/output.txt Total script time: 24.99 mins
|
|
/botio makeref |
From: Bot.io (Linux m4)ReceivedCommand cmd_makeref from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/b80e3293031365f/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/e7ffa60bdff6040/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/b80e3293031365f/output.txt Total script time: 18.33 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/e7ffa60bdff6040/output.txt Total script time: 24.84 mins
|
4 participants
Fonts that ship a BlueScale outside the range AFDKO considers valid for their zone heights (0.5/maxZoneHeight <= BlueScale <= 1/maxZoneHeight) cause Firefox's CFF rasterizer to misalign overshooting glyphs against flat-topped ones at body sizes.
Clamp into that window, only apply the lower clamp when BlueScale is also smaller than the default, so foundry fonts that pair the default 0.039625 with small zones are untouched.
Fixes #9437.