Skip to content

Use the #getPageL10nArgs helper in the PDFThumbnailView.prototype.addPasteButton method#21534

Merged
timvandermeij merged 1 commit into
mozilla:masterfrom
Snuffleupagus:addPasteButton-#getPageL10nArgs
Jul 3, 2026
Merged

Use the #getPageL10nArgs helper in the PDFThumbnailView.prototype.addPasteButton method#21534
timvandermeij merged 1 commit into
mozilla:masterfrom
Snuffleupagus:addPasteButton-#getPageL10nArgs

Conversation

@Snuffleupagus

Copy link
Copy Markdown
Collaborator

Rather than effectively duplicating code, we can re-use the existing helper here as well.

…addPasteButton` method

Rather than effectively duplicating code, we can re-use the existing helper here as well.
@codecov-commenter

codecov-commenter commented Jul 3, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.41%. Comparing base (0cc1718) to head (0c076f5).

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #21534   +/-   ##
=======================================
  Coverage   89.41%   89.41%           
=======================================
  Files         262      262           
  Lines       66760    66760           
=======================================
+ Hits        59691    59693    +2     
+ Misses       7069     7067    -2     
Flag Coverage Δ
browsertest 66.52% <ø> (-0.02%) ⬇️
integrationtest 68.74% <100.00%> (+<0.01%) ⬆️
unittest 57.32% <ø> (ø)
unittestcli 56.28% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@timvandermeij timvandermeij merged commit e414f74 into mozilla:master Jul 3, 2026
17 checks passed
@timvandermeij

Copy link
Copy Markdown
Collaborator

Thank you!

@Snuffleupagus Snuffleupagus deleted the addPasteButton-#getPageL10nArgs branch July 4, 2026 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants