Redis! Don't quit!

[digitarald]

Next up:

• Travis! Don't fail to run tests!
• Heroku! Don't fail to build!

[mention-bot]

By analyzing the blame information on this pull request, we identified @zalun, @brendandahl and @marco-c to be potential reviewers

[digitarald]

Tests are stuck with last line [23:56:14] Finished 'build' after 141 ms, but no other indication of failure in the logs.

[digitarald]

Can reproduce locally, tests don't start.

[digitarald]

We probably have a redis connection open in the root of the gulpfile: sindresorhus/gulp-imagemin#20 (comment)

[zalun]

If it hangs it means the connection to redis isn't closed.
We do not open redis connection in gulpfile, at least I don't see it there

[zalun]

There is a need to quit after all tests are done

bdd.after(() => digger.quitClient(5));

[zalun]

I see you don't quit database at all. That would mean gulp process will never end. It waits for redis connection to be finished

[zalun]

building status quite often creates new connection.
After adding console.logs at the beginning of readJSON and in getRequest just before creating new redis connection:

[15:23:13] Starting 'build:status'...
XXX: readJSON
XXX: creating new connection
XXX: readJSON
XXX: creating new connection
XXX: readJSON
XXX: creating new connection
XXX: readJSON
XXX: creating new connection
XXX: readJSON
XXX: creating new connection
[15:23:13] Starting 'build:css'...
[15:23:13] Starting 'build:js'...
[15:23:14] Finished 'build:engines' after 296 ms
[15:23:14] Finished 'build:tabzilla' after 292 ms
[15:23:14] Finished 'build:routes' after 305 ms
[15:23:14] Starting 'build:app'...
[15:23:14] Finished 'build:app' after 95 ms
[15:23:14] Finished 'build:css' after 724 ms
[15:23:14] Finished 'build:js' after 863 ms
[15:23:14] Finished 'build:root' after 910 ms
XXX: readJSON
[... a lot of XXX: readJSON ...]
XXX: readJSON

[zalun]

I've created #423 to show what I think is needed...
Unfortunately it involves opening and closing the redis connection at will

[digitarald]

test and build are fixed already