Added Manager, Contributor targeted logic and collapsible filters#3655
Conversation
Codecov Report❌ Patch coverage is 🚀 New features to boost your workflow:
|
Please make sure you use the right keyword to link to the corresponding issue. :) Looks like the Locales and Projects sections always appear on the review page: they shouldn't if Locales / Projects Filters are not used. Also, in the event that no projects/locales are selected (but the filter is used / expanded), the number of recipients should be zero. At the very end, I'd like to commit minor CSS changes. I think we'll need to use checkboxes instead of arrows to make it clearer when the filter is used. Then we'll also need to update the docs. |
|
Please also reference #3431 in the first comment if the intention is to fix that issue, too. Relatedly, if I don't enable filtering by locale and project, and target all 3 user roles, I'd expect all users to be recipients of the message. But the count for me locally reads 6,766, while there are 23,098 user accounts. If I select all locales and all projects, the recipient count is 6,069. |
|
Hmm that is very strange |
functionzz
force-pushed
the
feature/messaging_targeting_managers_translators
branch
from
e16e912 to
aa989df
Compare
mathjazz
left a comment
mathjazz
left a comment
There was a problem hiding this comment.
Getting there, just a few more minor things!
mathjazz
left a comment
mathjazz
left a comment
There was a problem hiding this comment.
!! Please DO NOT merge !!
The PR looks good, great work!
I'll commit a few CSS fixes as agreed previously.
!! Please DO NOT merge !!
|
I dunno, the green button is very tempting....... |
|
|
This commit adds collapsible filters to the messaging center, removes the minimum project/locale form requirements, changes the query logic and alters the form both in visuals and core logic.
This commit adds checkboxes instead of a dropdown for filters. It changes many styles. It edits the logic for filtering recipients and adds multiple form fields.
This commit adds validity checks ensuring that toggles are pressed when users fill out various fields. It addresses the review display and the fetch recipients numbers based on the toggle logic. Also added some minor css style changes and minor form field order changes.
Co-authored-by: Matjaž Horvat <matjaz.horvat@gmail.com>
Co-authored-by: Matjaž Horvat <matjaz.horvat@gmail.com>
mathjazz
force-pushed
the
feature/messaging_targeting_managers_translators
branch
from
cdb0092 to
777666e
Compare
|
@functionzz @flodolo Made a couple of CSS changes and simplified the code a little:
Please let me know if changes look good to you on stage: |
|
Looks good, didn't look at the functionality itself though. |
5 participants
Resolves #3453
Resolves #3431
One should now be able to singly target managers, translators and contributors of a specific project, and also singly target likewise of a specific locale. Furthermore, it adds collapsible filters to the messaging center, removes the minimum project/locale form requirements, changes the query logic and alters the form both in visuals and core logic.
This PR also includes some minor syntax changes to reflect a more consistent codebase.