This repository was archived by the owner on Jul 26, 2022. It is now read-only.
[#930039] Keeps project remix or edit status up to date on sing in sing ...#369
Closed
ScottDowne wants to merge 1 commit into
Closed
[#930039] Keeps project remix or edit status up to date on sing in sing ...#369ScottDowne wants to merge 1 commit into
ScottDowne wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Why not just put this logic in https://github.com/mozilla/popcorn.webmaker.org/blob/master/public/src/cornfield/module.js#L14? We do similar kinds of checks there already.
Contributor
Author
There was a problem hiding this comment.
loadFromSavedDataUrl and finishedCallback didn't exist in there, and I felt keeping it with the others made some sense.
i'm not married to it though :P
Contributor
There was a problem hiding this comment.
Why not just access the id via req.project.id? Just a small thing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
...out, and not just page load.