Make histogram parser to skip unknown properties#22
Merged
georgf merged 7 commits intomozilla:masterfrom Sep 6, 2017
georgf:master
Merged
Make histogram parser to skip unknown properties#22georgf merged 7 commits intomozilla:masterfrom georgf:master
georgf merged 7 commits intomozilla:masterfrom
georgf:master
Conversation
Aurora is going away, so Nightly/mozilla-central is now using BETA merge tags: https://hg.mozilla.org/mozilla-central/tags
The use counters implementation was updated to support custom counters: https://bugzilla.mozilla.org/show_bug.cgi?id=1175033 This means we need to update the parser here.
The probe-scraper job is currently broken as we introduced a new property for histograms that the tools here are not aware of. Until we merge/unify the parser tools, let’s skip unknown keys/properties here.
Contributor
|
The version in m-c already has this change. Can't we use that one and update this copy? Or is that what you are doing? |
Contributor
Author
|
We would need to two-way merge for that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The probe-scraper job is currently broken as we introduced a new
property for histograms that the tools here are not aware of.
Until we merge/unify the parser tools, let’s skip unknown
keys/properties here.