Refactor the color page to display token data (Fixes #80)#161
Merged
craigcook merged 1 commit intomozilla:masterfrom Jul 2, 2018
alexgibson:update-colors
Merged
Refactor the color page to display token data (Fixes #80)#161craigcook merged 1 commit intomozilla:masterfrom alexgibson:update-colors
craigcook merged 1 commit intomozilla:masterfrom
alexgibson:update-colors
Conversation
Contributor
Author
|
Ok, mozilla/protocol-tokens#20 is resolved so this is now ready for review. |
craigcook
approved these changes
Jul 2, 2018
Contributor
craigcook
left a comment
craigcook
left a comment
There was a problem hiding this comment.
Looks good, though next we'll need to figure out a way to group colors and probably redesign our swatches. But one step at a time...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the colors page to consume
@mozilla-protocol/tokenscolors. This is probably a first-step to a better designed colors page. We really need to do some further work in the tokens repo to group colors for display, so each can have a heading/separate list. This PR at least means we can finally show our up-to-date color pallet in the docs (which will keep current automatically).Blocked by mozilla/protocol-tokens#20