Add vendor prefixes to flex box uses (#218)#351
Merged
stephaniehobson merged 1 commit intomozilla:masterfrom Apr 3, 2019
stephaniehobson:flex
Merged
Add vendor prefixes to flex box uses (#218)#351stephaniehobson merged 1 commit intomozilla:masterfrom stephaniehobson:flex
stephaniehobson merged 1 commit intomozilla:masterfrom
stephaniehobson:flex
Conversation
stephaniehobson
added
Needs:Review 👋
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Uses the
flexboxmixin to add vendor prefixes in places where we wantdisplay: flexI have documented this change in the design system.CHANGELOG.md.Issue
Fix #218 and a few other places where the code was the same and so might have had duplicate bugs.
Testing
I left the one
display: flexinside the@supportsdeclaration because I think we would have to re-write the@supportsdeclaration for each prefix.Check the Call Out and Feature Card components.