Newletter.js only runs when there is a newsletter (#400)#402
Merged
alexgibson merged 1 commit intomozilla:masterfrom Jul 9, 2019
stephaniehobson:newsletter
Merged
Newletter.js only runs when there is a newsletter (#400)#402alexgibson merged 1 commit intomozilla:masterfrom stephaniehobson:newsletter
alexgibson merged 1 commit intomozilla:masterfrom
stephaniehobson:newsletter
Conversation
alexgibson
approved these changes
Jul 9, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Describe what this change does.
I have documented this change in the design system.CHANGELOG.md.Issue
Fix #400
Testing
Include newsletter.js in a component that doesn't need it on the master branch, verify you get the error, switch to this branch and verify you do not.
<script src="{{@root.baseurl}}/assets/protocol/protocol/js/protocol-newsletter.js"></script>