Separate newsletter form and newsletter layout styling (#444)#464
Merged
stephaniehobson merged 1 commit intomozilla:masterfrom Sep 4, 2019
stephaniehobson:newsletter
Merged
Separate newsletter form and newsletter layout styling (#444)#464stephaniehobson merged 1 commit intomozilla:masterfrom stephaniehobson:newsletter
stephaniehobson merged 1 commit intomozilla:masterfrom
stephaniehobson:newsletter
Conversation
stephaniehobson
added
Needs:Review 👋
Errolyn
approved these changes
Sep 3, 2019
Contributor
Errolyn
left a comment
Errolyn
left a comment
There was a problem hiding this comment.
Looks good, works locally 🗡
r+ 🐮
Will need a rebase before it is merged.
- edited form styles to work when not nested under .mzp-c-newsletter - moved all two column/grid styles to only apply when nested under .mzp-c-newsletter
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We should be able to embed the newsletter form in places where we don't want an image next to it. So, I have separated the form formatting from the layout when used with an image.
edited form styles to work when not nested under .mzp-c-newsletter
moved all two column/grid styles to only apply when nested under .mzp-c-newsletter
I have recorded this change in
CHANGELOG.md.Issue
Fix #444
Testing