Update @mozilla-protocol/assets to 2.1.1 (#479)#480
Closed
stephaniehobson wants to merge 1 commit intomozilla:masterfrom
stephaniehobson:assets
Closed
Update @mozilla-protocol/assets to 2.1.1 (#479)#480stephaniehobson wants to merge 1 commit intomozilla:masterfrom stephaniehobson:assets
stephaniehobson wants to merge 1 commit intomozilla:masterfrom
stephaniehobson:assets
Conversation
Contributor
Author
|
@alexgibson Could you have a look at the package-lock file please? It added a bunch of stuff as "optional" when I ran the upgrade. |
stephaniehobson
added
P1
Contributor
|
@stephaniehobson try updating the version of npm you have installed locally on your machine. |
Contributor
Author
|
The package-lock file is co-operating now :) This is ready for a general code review. |
Contributor
Author
|
Closing this in favour of going straight to 3.0.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Describe what this change does.
I have documented this change in the design system.CHANGELOG.md.Issue
Fix #479
Testing
uifolder have been moved-blackin the file name.