Skip to content

add component issue templates#484

Merged
craigcook merged 1 commit intomasterfrom
component-issue-templates
Sep 16, 2019
Merged

add component issue templates#484
craigcook merged 1 commit intomasterfrom
component-issue-templates

Conversation

@johngruen
Copy link
Copy Markdown
Contributor

@johngruen johngruen commented Sep 13, 2019

Description

This adds issue templates for creating new components and updating existing components

  • I have documented this change in the design system.
  • I have recorded this change in CHANGELOG.md.

Issue

This resolves #379

Testing

No testing necessary, this is a documentation change

Copy link
Copy Markdown
Contributor

@craigcook craigcook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one stray character we should remove, otherwise this is awesome! 🎉

Comment thread src/pages/docs/contributing.md Outdated
@johngruen johngruen force-pushed the component-issue-templates branch from 3ec2914 to d6ac742 Compare September 13, 2019 19:35
@johngruen
Copy link
Copy Markdown
Contributor Author

@craigcook should be good now

Copy link
Copy Markdown
Contributor

@craigcook craigcook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍤

@craigcook craigcook merged commit f50beb8 into master Sep 16, 2019
@craigcook craigcook deleted the component-issue-templates branch September 16, 2019 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Document how to specify a new component

2 participants