Merged
Conversation
stephaniehobson
added
Review: XS
craigcook
suggested changes
Oct 29, 2019
Contributor
There was a problem hiding this comment.
Looks good, though I think the selector is missing a strong.
Thinking further, if we're at all concerned about loose matching of attribute selectors, we could make it more explicit with a class like mzp-has-zap and then extend that with the theme classes to tell it which zap to use. But it's still unlikely that someone would have something named foo-mzp-t-zap or mzp-t-zap-42 or mzp-t-zappbrannigan etc, so matching an attribute selectors is probably fine.
I'd like to eventually include more design guidance around when and how to use a zap. We need better design guidelines overall so that doesn't have to be part of this PR right now.
Contributor
Author
|
Updated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add zap component.
CHANGELOG.md.Issue
Fix #511
Testing
This change depends on #510, make sure you're running the latest protocol-assets.