Fix min install date#189
Merged
acmiyaguchi merged 2 commits intomozilla:masterfrom Feb 16, 2018
benmiroglio:fix-min-install-date
Merged
Fix min install date#189acmiyaguchi merged 2 commits intomozilla:masterfrom benmiroglio:fix-min-install-date
acmiyaguchi merged 2 commits intomozilla:masterfrom
benmiroglio:fix-min-install-date
Conversation
Contributor
|
Can you rebase your changes on master? It's hard to review the diffs. |
Codecov Report
@@ Coverage Diff @@
## master #189 +/- ##
=======================================
Coverage 65.67% 65.67%
=======================================
Files 42 42
Lines 1923 1923
=======================================
Hits 1263 1263
Misses 660 660
Continue to review full report at Codecov.
|
acmiyaguchi
approved these changes
Feb 15, 2018
Contributor
acmiyaguchi
left a comment
acmiyaguchi
left a comment
There was a problem hiding this comment.
This looks good to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added logic to only record
first_addon_install_datefor self-installed add-ons, otherwise it should benull. This was an oversight from the initial script, and I'd like to backfill through 2017-10-01.r? @acmiyaguchi