Skip to content

Bug 1451907 - Add default_search_engine column to search aggregates#230

Merged
wlach merged 1 commit intomozilla:masterfrom
wlach:add-default-search-engine-column-to-search-aggregates
May 24, 2018
Merged

Bug 1451907 - Add default_search_engine column to search aggregates#230
wlach merged 1 commit intomozilla:masterfrom
wlach:add-default-search-engine-column-to-search-aggregates

Conversation

@wlach
Copy link
Copy Markdown
Contributor

@wlach wlach commented May 24, 2018

No description provided.

@wlach wlach requested a review from harterrt May 24, 2018 20:21
Copy link
Copy Markdown
Contributor

@harterrt harterrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #230 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #230   +/-   ##
=======================================
  Coverage   57.07%   57.07%           
=======================================
  Files          47       47           
  Lines        2479     2479           
=======================================
  Hits         1415     1415           
  Misses       1064     1064
Impacted Files Coverage Δ
mozetl/search/aggregates.py 69.56% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d538e7...e430364. Read the comment docs.

@wlach wlach merged commit 0f8189f into mozilla:master May 24, 2018
@wlach wlach deleted the add-default-search-engine-column-to-search-aggregates branch May 24, 2018 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants