Skip to content

Conversation

@squarewave
Copy link
Contributor

This PR just outputs an additional file containing hangs in child processes by piping through a config variable with the process name to filter on instead of hard-coding "Gecko."

@squarewave
Copy link
Contributor Author

( @BenWu )

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 32.47%. Comparing base (b4fd5f3) to head (e786f72).

Files Patch % Lines
mozetl/bhr_collection/bhr_collection.py 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #400      +/-   ##
==========================================
- Coverage   32.48%   32.47%   -0.01%     
==========================================
  Files          36       36              
  Lines        3876     3877       +1     
==========================================
  Hits         1259     1259              
- Misses       2617     2618       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@BenWu BenWu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes make sense to me. I started running it on my computer but it's taking a long time so it hasn't finished yet. I'm happy to just merge it

"use_s3": not use_gcs,
},
)
etl_job_daily(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say it's better to change the etl_job_daily function to reuse the intermediate results instead of running this twice but I doubt it's worth the effort. The job currently takes ~1.5 hours to run and this would double it

@BenWu BenWu merged commit 0fd86bd into mozilla:main Apr 17, 2024
@BenWu
Copy link
Contributor

BenWu commented Apr 17, 2024

Updated job should run tomorrow. Status can be found in airflow https://workflow.telemetry.mozilla.org/dags/bhr_collection/grid

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants