Bug 1310075 - Tests for qq.com. r=Gijs#316
Merged
gijsk merged 1 commit intomozilla:masterfrom Nov 9, 2016
Merged
Conversation
gijsk
approved these changes
Nov 9, 2016
| @@ -0,0 +1,6 @@ | |||
| { | |||
| "title": "DeepMind新电脑已可利用记忆自学 人工智能迈上新台阶_科技_腾讯网", | |||
| "byline": null, | |||
Contributor
There was a problem hiding this comment.
Should we file a followup issue to detect a byline, or is there no author (clearly/semantically) specified? I'm afraid I can't speak/read Chinese, and Google Translate was not very helpful. Based on its "translation", it looks to me like there's an author at the end of the article（编译/林靖东）but I can't see any specific markup around that, and I don't know if the same information is in some of the metadata elsewhere.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@gijsk ,
I've added tests for qq.com. (the
source.htmlis from 1)Could you help review the patch?
Thanks.