Fix bug 1322674 by only conditionally removing content from tables when the tables are layout tables#348
Merged
evanxd merged 2 commits intomozilla:masterfrom Feb 9, 2017
Merged
Conversation
Contributor
|
Looks good to me. |
evanxd
reviewed
Feb 9, 2017
| var p = node.getElementsByTagName("p").length; | ||
| var img = node.getElementsByTagName("img").length; | ||
| var li = node.getElementsByTagName("li").length-100; | ||
| var li = node.getElementsByTagName("li").length - 100; |
Contributor
There was a problem hiding this comment.
Let's add new eslint rules to avoid the bad code style like this. Already filed a follow up issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@evanxd I wrote up a fix for bug 1322674. I also added some extra debugging logic to the test runner script. Can you take a look?