This repository was archived by the owner on Nov 11, 2019. It is now read-only.
codecoverage/bot: Upload coverage data to Phabricator using arcanist autotarget #1723
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marco-c
force-pushed
the
upload_to_phabricator_2
branch
3 times, most recently
from
e7f702f to
0cc36c2
Compare
La0
approved these changes
Dec 11, 2018
| ''' | ||
| Find details of a differential revision | ||
| ''' | ||
| assert rev_phid is not None or rev_id is not None |
| rev_data = phabricator.load_revision(rev_id=rev_id) | ||
| phabricator.upload_coverage_results(rev_data['fields']['diffPHID'], coverage) | ||
| # XXX: This is only necessary until https://bugzilla.mozilla.org/show_bug.cgi?id=1487843 is resolved. | ||
| phabricator.upload_lint_results(rev_data['fields']['diffPHID'], 'pass', []) |
Contributor
There was a problem hiding this comment.
So you already had the implementation but were not using it ?
Collaborator
Author
There was a problem hiding this comment.
Yes, for a few months 😄
| params = json.loads(urllib.parse.parse_qs(call.request.body)['params'][0]) | ||
| assert params['buildTargetPHID'] == 'PHID-HMBT-test' | ||
| assert params['type'] == 'pass' | ||
| assert params['unit'] == [{'name': 'Aggregate coverage information', 'result': 'pass', 'coverage': {'file': 'NUCCCCU'}}] |
marco-c
force-pushed
the
upload_to_phabricator_2
branch
from
0cc36c2 to
c5fbc1c
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a temporary implementation until https://bugzilla.mozilla.org/show_bug.cgi?id=1487843 is resolved. The implementation won't change much after that, so most of the code will still be useful.