Skip to content
This repository was archived by the owner on Nov 11, 2019. It is now read-only.

Conversation

@La0
Copy link
Contributor

@La0 La0 commented Apr 23, 2019

Fix this bug

@sylvestre
Copy link
Contributor

Oh, Python :)

@marco-c
Copy link
Collaborator

marco-c commented Apr 23, 2019

Could you check what is the patch generated by clang-format like here? Maybe we are missing something

@La0
Copy link
Contributor Author

La0 commented Apr 23, 2019

The parsed patch provided by parsepatch is:

# file: netwerk/protocol/http/nsHttpHandler.h
{'added': [], 'deleted': [426], 'touched': [], 'new': False}

The raw patch is:

diff -r b783cd5203ea netwerk/protocol/http/nsHttpHandler.h
--- a/netwerk/protocol/http/nsHttpHandler.h	Tue Apr 23 08:38:57 2019 +0000
+++ b/netwerk/protocol/http/nsHttpHandler.h	Mon Apr 22 12:41:08 2019 +0300
@@ -418,17 +418,16 @@
   void SetLastActiveTabLoadOptimizationHit(TimeStamp const &when);
   bool IsBeforeLastActiveTabLoadOptimization(TimeStamp const &when);

   bool DumpHpackTables() { return mDumpHpackTables; }

   HttpTrafficAnalyzer *GetHttpTrafficAnalyzer();

   bool GetThroughCaptivePortal() { return mThroughCaptivePortal; }
-
  private:
   nsHttpHandler();

   virtual ~nsHttpHandler();

   MOZ_MUST_USE nsresult Init();

   //

@marco-c
Copy link
Collaborator

marco-c commented Apr 23, 2019

Maybe we should consider deleted lines too then?

@La0
Copy link
Contributor Author

La0 commented Apr 23, 2019

Yeah that's why I added @calixteman on this issue: is there a reason the deleted lines are ignored ?

@La0 La0 force-pushed the sa-fix-clang-format branch from 3f128d2 to 7dc2a5e Compare April 23, 2019 09:01
@La0 La0 merged commit 30fe29c into mozilla:master Apr 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants