This repository was archived by the owner on Nov 11, 2019. It is now read-only.
Use phabricator client from libmozdata #2130
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Depends on mozilla/libmozdata#162 After a new build with git revision in nix packages, i'll release libmozdata on Pypi, then update the final requirements. |
Contributor
Author
|
@marco-c I released a new version of libmozdata, and use it here... Should be good to go if the build is green ! |
marco-c
reviewed
May 25, 2019
| # This Source Code Form is subject to the terms of the Mozilla Public | ||
| # License, v. 2.0. If a copy of the MPL was not distributed with this | ||
| # file, You can obtain one at http://mozilla.org/MPL/2.0/. | ||
|
|
Collaborator
There was a problem hiding this comment.
We could actually remove the Phabricator endpoint in codecoverage/backend, #1992.
Contributor
Author
There was a problem hiding this comment.
I did a PR for that, and rebased this one on top (first 2 commits): no more src/codecoverage/backend changes here.
marco-c
reviewed
May 25, 2019
marco-c
reviewed
May 25, 2019
marco-c
reviewed
May 25, 2019
Contributor
Author
|
This will need a rebase once #2132 lands |
added 7 commits
May 27, 2019 11:15
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.