Skip to content

Fix expire orphan attachment job, event hold not required #1073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
leplatrem merged 2 commits into from
Nov 12, 2025
Merged

Fix expire orphan attachment job, event hold not required #1073

leplatrem merged 2 commits into from
Nov 12, 2025

Conversation

@leplatrem
Copy link
Contributor

@leplatrem leplatrem commented Nov 12, 2025 •
edited
Loading

Last run didn't do anything:

Screenshot 2025-11-12 at 10 18 26

Running manually failed:

    return self._do_request(
           ^^^^^^^^^^^^^^^^^
  File "/Users/mathieu/Code/Mozilla/remote-settings/.venv/lib/python3.12/site-packages/google/cloud/storage/batch.py", line 213, in _do_request
    raise ValueError(
ValueError: Too many deferred requests (max 1000)

@leplatrem leplatrem requested a review from a team as a code owner November 12, 2025 09:16
@leplatrem leplatrem added the bug Something isn't working label Nov 12, 2025
@leplatrem leplatrem merged commit fd16d2d into main Nov 12, 2025
14 of 15 checks passed
@leplatrem leplatrem deleted the fix-expire-attachments branch November 12, 2025 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexcottner alexcottner alexcottner approved these changes

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@leplatrem @alexcottner