Npm module refresh, eslint, node@8, test refactoring#29
Merged
vladikoff merged 24 commits intomozilla:masterfrom Jul 30, 2018
Merged
Npm module refresh, eslint, node@8, test refactoring#29vladikoff merged 24 commits intomozilla:masterfrom
vladikoff merged 24 commits intomozilla:masterfrom
Conversation
… recent; mocha to 3.5.3 for node4
vladikoff
approved these changes
Jul 30, 2018
jbuck
approved these changes
Jul 30, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A yak-shave.
npm test.Updating mailparser means rewriting the email handling to streams3. I'd rather get this set of changes live with the node@8 change. More tests should be added to check proper handling of text+html multipart messages, so I don't regress current handling with an update to mailparser@2.x.
r? - @jbuck, @vladikoff, @rfk (but @rfk is on pto).