Merged
Conversation
jrgm
commented
Aug 1, 2018
| module.exports = function(cb) { | ||
| server.listen(0, function(err) { | ||
| var port = process.env.PORT || 0; | ||
| server.listen(port, function(err) { |
Contributor
Author
There was a problem hiding this comment.
This makes it possible to test with a background emailserver (although you also have to disable the startup of the one built in to the test). Useful for local development.
jrgm
commented
Aug 1, 2018
| (res.statusCode).should.equal(200); | ||
| done(); | ||
| }).end(); | ||
| }); |
Contributor
Author
There was a problem hiding this comment.
I was lazy, and just copy/pasted.
Contributor
Author
|
Fixes #28 |
jbuck
approved these changes
Aug 1, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
r? - @vladikoff, @jbuck
This puts in restrictions:
will result in rejection of the request.
If i need to adjust these limits, they can be set via the environment.