Skip to content

update the blake3 dependency to v1#1062

Closed
oconnor663 wants to merge 1 commit intomozilla:mainfrom
oconnor663:patch-1
Closed

update the blake3 dependency to v1#1062
oconnor663 wants to merge 1 commit intomozilla:mainfrom
oconnor663:patch-1

Conversation

@oconnor663
Copy link

The blake3 crate currently has a MSRV of 1.51 for const generics.

@sylvestre
Copy link
Collaborator

The ci fails with


    Updating crates.io index
error: the lock file /home/runner/work/sccache/sccache/Cargo.lock needs to be updated but --locked was passed to prevent this
If you want to try to generate the lock file without accessing the network, use the --offline flag.
Error: Process completed with exit code 101.

The blake3 crate currently has a MSRV of 1.51 for const generics.
@oconnor663
Copy link
Author

Thanks, added the lockfile changes and force pushed.

@oconnor663
Copy link
Author

Ah it looks like there are some CI runs that test rustc 1.43. This PR will have to wait until it's ok to bump the MSRV.

@mitchhentges
Copy link
Contributor

Hey, thanks for the patch!
I'm going to close this because we're going to do a larger update-bump pass, which is also contingent on us having a more concrete understanding of the restrictions on having the MSRV bumped.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants