Move cmake-modules to integration tests#2649
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2649 +/- ##
=======================================
Coverage 73.38% 73.38%
=======================================
Files 68 68
Lines 37338 37338
=======================================
Hits 27400 27400
Misses 9938 9938 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
cc @TroyKomodo |
|
This looks like a much better way to do the integration tests. More scalable! Personally I would reach for snapshotting here for the json stats output since it shouldn't be changing run-to-run. Right now we just check that at least one file was cached. This might be something for a broader change across all the integration tests. Cc @sylvestre |
|
By snapshotting, I guess you mean the number of misses/hits. Because the full output looks redundant and can change at any time. Although the whole integration test checks whether the values change, not the exact numbers. Not sure if it's worth diverging now, or rather a small refactoring in the future. Additionally, it was suspicious that tests work in docker and fail in https://github.com/mozilla/sccache/actions/runs/23459356336/job/68257326892?pr=2581#step:10:38. I added cmake 4.0 test with |
98d77fc to
42afcdd
Compare
42afcdd to
184b827
Compare
A few improvements:
make test-toolsto launch locallytests/integrationdirectory