fix: rollback pending state on tempfile failure in prepare_add#2689
Open
srpatcha wants to merge 1 commit intomozilla:mainfrom
Open
fix: rollback pending state on tempfile failure in prepare_add#2689srpatcha wants to merge 1 commit intomozilla:mainfrom
srpatcha wants to merge 1 commit intomozilla:mainfrom
Conversation
prepare_add updated pending size before tempfile_in(), which never rolled back on failure. This caused make_space() to panic later when encountering negative available space. Moved state update after successful tempfile creation and replaced .expect() with ? operator. Signed-off-by: Srikanth Patchava <spatchava@meta.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
\prepare_add\ updated pending size before \ empfile_in(), which never rolled back on failure. This caused \make_space()\ to panic later when encountering negative available space.
Moved state update after successful tempfile creation and replaced .expect()\ with ?\ operator.
This is split from #2679 per reviewer feedback to keep changes focused.
Changes
Signed-off-by: Srikanth Patchava spatchava@meta.com