gcc: Force local compilation on dist-client when assembler has .incbin#2703
gcc: Force local compilation on dist-client when assembler has .incbin#2703lissyx wants to merge 1 commit into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2703 +/- ##
=======================================
Coverage 74.34% 74.35%
=======================================
Files 70 70
Lines 39373 39389 +16
=======================================
+ Hits 29271 29286 +15
- Misses 10102 10103 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Assembly files with .incbin would trigger a build failure when running over sccache-dist: > 0:03.40 E /home/alex/firefox/gecko-cinnabar/config/external/icu/data/icu_data.S:28:9: error: Could not find incbin file '/home/alex/firefox/gecko-cinnabar/config/external/icu/data/icudt78l.dat' Force disable distributed compilation when hitting such a file.
lissyx
force-pushed
the
issue2700_incbin_sccache_dist
branch
from
bfba315 to
b02b310
Compare
|
|
||
| #[cfg(feature = "dist-client")] | ||
| let assembler_has_incbin = match Language::from_file_name(parsed_args.input.clone().as_path()) { | ||
| Some(Language::AssemblerToPreprocess) => { |
There was a problem hiding this comment.
This should be checked for any assembly or C language, because the last one may contain inline ASM with that directive and the same problem
There was a problem hiding this comment.
I'm afraid it's going to be a lot of useless IOs reading those content then?
| let assembler_has_incbin = match Language::from_file_name(parsed_args.input.clone().as_path()) { | ||
| Some(Language::AssemblerToPreprocess) => { | ||
| let mut contents = String::new(); | ||
| let res = File::open(parsed_args.input.clone()) |
There was a problem hiding this comment.
And we cannot just use the source file - we must check the preprocessor output - the .incbin directive may come from the included header file
|
One more question about your original issue: can you use relative path as an P.S. The problem looks like the same we have with an |
3 participants
Assembly files with .incbin would trigger a build failure when running over sccache-dist:
Force disable distributed compilation when hitting such a file.