Conversation
|
The Travis build failure looks like a missing crate declaration in the dist code: |
|
Never tested with |
| where T: CommandCreatorSync | ||
| { | ||
| trace!("detect_compiler"); | ||
| trace!("detect_compiler: {}", executable.display()); |
There was a problem hiding this comment.
You know, I was just looking at a log file from our CI the other day and realizing that this log message was not very informative. :)
| extern crate assert_cmd; | ||
| extern crate chrono; | ||
| extern crate env_logger; | ||
| extern crate escargot; |
There was a problem hiding this comment.
Just curious--what does escargot buy us over the existing assert_cmd usage?
| access_information: CISProfileV2AccessInformation, | ||
| } | ||
| let profile: CISProfileV2 = res.json().chain_err(|| "Cannot decode CIS V2 profile from person API")?; | ||
| let is_allowed = profile.access_information.ldap.value.into_iter().any(|item| item.name == "hris_dept_firefox"); |
There was a problem hiding this comment.
I'm not 100% confident that this is the check we want here, but maybe it's close enough for now? I don't know if "is a MoCo employee" would be considered too broad? We should probably ask the security folks for clarification.
|
I won't claim that I've understood the meat of the authentication code here, but I've given everything a once-over and don't see anything that worries me so I'm going to merge this. If we discover problems in testing we can land fixes in separate PRs. |
2 participants
If you test with the dist-tests feature on Linux, it will do the selenium tests in docker.
I also rolled in the suggested extraction of token checking into different functions.