replace outdated rust-crypto crate with RustCrypto/hashes#540
replace outdated rust-crypto crate with RustCrypto/hashes#540AnderEnder wants to merge 1 commit intomozilla:masterfrom
Conversation
alexcrichton
left a comment
There was a problem hiding this comment.
Hm sorry I don't really remember much of this code, so if I was the one that added rust-crypto at some point I don't really remember that either. I'm probably not the best reviewer for this :(
|
There's an existing PR for this work that's been sitting due to some open questions: #310 |
|
Ah, ok, I figured this would be a trivial issue for someone familiar with the rust crypto ecosystem, but I will take a deeper dive into the context in #310 and figure out what to do. |
b2a458c to
74c64f3
Compare
|
I ended up taking care of this in #570, thank you for bringing this to our attention! |
|
@chmanchester, why the PR was not reviewed and closed, but all changes were moved to another one? |
|
@AnderEnder by the time I got around to testing the change I found an issue, made a fix locally, and also noticed things needed to be re-based, so it seemed easier to start over. Sorry about that, we should have gotten to this earlier. |
Issue: rust-crypto is unmaintained and outdated crate:
Implementation: replace rust-crypto with RustCrypto crates