Skip to content

replace outdated rust-crypto crate with RustCrypto/hashes#540

Closed
AnderEnder wants to merge 1 commit intomozilla:masterfrom
AnderEnder:migration-from-rust-crypto
Closed

replace outdated rust-crypto crate with RustCrypto/hashes#540
AnderEnder wants to merge 1 commit intomozilla:masterfrom
AnderEnder:migration-from-rust-crypto

Conversation

@AnderEnder
Copy link
Copy Markdown

Issue: rust-crypto is unmaintained and outdated crate:

Implementation: replace rust-crypto with RustCrypto crates

Copy link
Copy Markdown
Contributor

@alexcrichton alexcrichton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm sorry I don't really remember much of this code, so if I was the one that added rust-crypto at some point I don't really remember that either. I'm probably not the best reviewer for this :(

@luser
Copy link
Copy Markdown
Contributor

luser commented Oct 15, 2019

There's an existing PR for this work that's been sitting due to some open questions: #310

@chmanchester
Copy link
Copy Markdown
Contributor

Ah, ok, I figured this would be a trivial issue for someone familiar with the rust crypto ecosystem, but I will take a deeper dive into the context in #310 and figure out what to do.

@AnderEnder AnderEnder force-pushed the migration-from-rust-crypto branch from b2a458c to 74c64f3 Compare October 16, 2019 23:14
@chmanchester
Copy link
Copy Markdown
Contributor

I ended up taking care of this in #570, thank you for bringing this to our attention!

@AnderEnder
Copy link
Copy Markdown
Author

@chmanchester, why the PR was not reviewed and closed, but all changes were moved to another one?

@chmanchester
Copy link
Copy Markdown
Contributor

@AnderEnder by the time I got around to testing the change I found an issue, made a fix locally, and also noticed things needed to be re-based, so it seemed easier to start over. Sorry about that, we should have gotten to this earlier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants