Skip to content
This repository was archived by the owner on May 22, 2021. It is now read-only.

Use compat build of Fluent#1489

Closed
kellda wants to merge 1 commit intomozilla:masterfrom
kellda:fluent-compat
Closed

Use compat build of Fluent#1489
kellda wants to merge 1 commit intomozilla:masterfrom
kellda:fluent-compat

Conversation

@kellda
Copy link
Copy Markdown

@kellda kellda commented Jul 5, 2020

Use compat build of fluent to support Edge older than 79.

See projectfluent/fluent.js#431 and WebThingsIO/gateway#2238

Fixes #1487

@stasm
Copy link
Copy Markdown
Contributor

stasm commented Jul 8, 2020

Hi, I'm the maintainer of Fluent and the @fluent family of packages on npm. While using the compat build will likely help fix the issue at hand, I'd like to point out that last week I released new versions of all @fluent packages which don't ship with the compat.js builds anymore. This includes @fluent/bundle 0.16.0. The code that we now ship is transpiled by TypeScript to ES2018. More info: projectfluent/fluent.js#472, projectfluent/fluent.js#479, as well as projectfluent/fluent.js#431 (comment).

If you go ahead and merge this, please do it as a hot-fix rather than a longer-term solution. In my opinion the right solution is to transpile node_modules/@fluent during Send's build. This will help ensure that you ship code which meets your compatibility criteria to the letter, and will make it easier to upgrade to new versions of @fluent/bundle in the future.

Interestingly, it looks like Send's config for Webpack already explicitly includes node_modules/@fluent:

path.resolve(__dirname, 'node_modules/@fluent'),

Perhaps that config line doesn't work as intended and that's what's causing the bug?

@dannycoates
Copy link
Copy Markdown
Contributor

Thanks for looking at this @kellda. I fixed it a different way by adding edge 18 to the browserlist file

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Empty page on Edge 18

3 participants