This repository was archived by the owner on May 22, 2021. It is now read-only.
Begin implementing a reporting mechanism#1496
Merged
dannycoates merged 2 commits intomozilla:masterfrom Jul 24, 2020
Merged
Conversation
flodolo
reviewed
Jul 24, 2020
| *[other] Report these files as suspicious | ||
| } | ||
| reportDescription = Help us understand what’s going on. What do you think is wrong with these files? | ||
| reportUnknownDescription = Please go to the url of the link you wish to report and click “{ reportFile }”. |
Collaborator
There was a problem hiding this comment.
This should display the plural form, since it's the default. Can you confirm that works?
dannycoates
force-pushed
the
dear-nice-things-too
branch
from
7b3e815 to
9891d1f
Compare
flodolo
approved these changes
Jul 24, 2020
Contributor
Author
|
Thanks @flodolo |
fzzzy
reviewed
Jul 24, 2020
| render(); | ||
| } catch (err) { | ||
| console.error(err); | ||
| if (err.message === '404') { |
Contributor
There was a problem hiding this comment.
Does this actually happen every time?
Contributor
Author
There was a problem hiding this comment.
No,
/api/report returns
- 200 - when the link was already flagged or was successfully flagged. Note that the file may already be "dead"
- 400 - when the submitted
keycan't decrypt the metadata. This is to prevent reporting ids without knowing the full url - 404 - when the id has fully expired and deleted from redis. An api delete just marks the id as dead now so that we can accept reports for files that have already hit max download count
If it's a 404 we don't want to say there was an error
dannycoates
force-pushed
the
dear-nice-things-too
branch
from
66f28ed to
17057e7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.