This repository was archived by the owner on May 22, 2021. It is now read-only.
Delete button enhancement#486
Closed
perezbrandon wants to merge 2 commits intomozilla:masterfrom
perezbrandon:delete-button-enhancement
Closed
Delete button enhancement#486perezbrandon wants to merge 2 commits intomozilla:masterfrom perezbrandon:delete-button-enhancement
perezbrandon wants to merge 2 commits intomozilla:masterfrom
perezbrandon:delete-button-enhancement
Conversation
Contributor
|
Screenshot of new "Delete" button UI in #483 (comment) |
Contributor
|
@youwenliang thoughts? |
Contributor
|
From UX perspective the primary button on this screen should be the "copy link" button so we wouldn't want the red delete button to jump out and distract users. Maybe we can do something more subtle like this: And ideally, we should also put a confirmation dialog here just in case. (same as the one in the homepage) |
Contributor
|
Making the delete button red isn't what we want anymore. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
delete button enhancement, gave it a red background to stand out more.
Fixes #220