Correctly parse URL where host includes "-" #276
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
urlParse was mis-parsing URLs where the host included "-". This fixes the problem by modifying the parsing regexp. Fixes mozilla#219
gregtatum
approved these changes
Sep 22, 2017
Member
gregtatum
left a comment
gregtatum
left a comment
There was a problem hiding this comment.
Thanks, this looks good to me. Feel free to ping me in the future for source map related PRs. I read through the spec, docs, and source code today, so I should be able to look into anything that needs reviewing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
urlParse was mis-parsing URLs where the host included "-".
This fixes the problem by modifying the parsing regexp.
Fixes #219