Slightly loosen urlRegexp #285
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julienw
approved these changes
Sep 25, 2017
julienw
left a comment
julienw
left a comment
There was a problem hiding this comment.
lgtm !
Please wait for a green Travis before merging :)
test/test-source-map-consumer.js
Outdated
| "names":[], | ||
| "mappings":"CAAS", | ||
| "file":"static/js/manifest.b7cf97680f7a50fa150f.js", | ||
| "sourceRoot":"" |
There was a problem hiding this comment.
nit: no need to quote the keys here :) Also, please add spaces after the colons.
(would make sense to add prettier eventually)
| exports.getArg = getArg; | ||
|
|
||
| var urlRegexp = /^(?:([\w+\-.]+):)?\/\/(?:(\w+:\w+)@)?([\w.-]*)(?::(\d+))?(\S*)$/; | ||
| var urlRegexp = /^(?:([\w+\-.]+):)?\/\/(?:(\w+:\w+)@)?([\w.-]*)(?::(\d+))?(.*)$/; |
There was a problem hiding this comment.
While reviewing, I realized that in isAbsolute, you should use urlRegexp.test(aPath) instead of aPath.match(urlRegexp) because you don't need the matches, so it should be faster. You can do it in this patch or in another patch if you want.
Contributor
Author
There was a problem hiding this comment.
Actually, this change causes many regressions.
Contributor
Author
There was a problem hiding this comment.
... because I wrote it incorrectly.
tromey
force-pushed
the
url-parsing-fix
branch
from
c15fe60 to
aa490fb
Compare
urlRegexp was requiring that there be no spaces in the path component of the URL. However, this is overly strict; and in particular webpack creates URLs with an embedded space. Fixes mozilla#267
tromey
force-pushed
the
url-parsing-fix
branch
from
aa490fb to
d21b0e1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
urlRegexp was requiring that there be no spaces in the path component of
the URL. However, this is overly strict; and in particular webpack
creates URLs with an embedded space.
Fixes #267